From a2f6579380c310e89dcd032001947029c7884b3e Mon Sep 17 00:00:00 2001 From: aradhyacp Date: Tue, 30 Dec 2025 06:50:41 +0530 Subject: [PATCH] Clarify error reporting logic in binwalk analyzer comments --- aperisolve/analyzers/binwalk.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/aperisolve/analyzers/binwalk.py b/aperisolve/analyzers/binwalk.py index c3d1f2e..69920e7 100644 --- a/aperisolve/analyzers/binwalk.py +++ b/aperisolve/analyzers/binwalk.py @@ -44,6 +44,8 @@ def analyze_binwalk(input_img: Path, output_dir: Path) -> None: if extracted_dir.exists(): shutil.rmtree(extracted_dir) + # Only report error if stderr exists AND extraction failed. + # If zip_exist is True, binwalk worked (despite warnings), so we proceed. if len(stderr) > 0 and not zip_exist: err = { "binwalk": {