Merge pull request #119 from aradhyacp/issue/jar-binwalk-fix

Fix missing Binwalk dependencies (jar) and improve extraction error handling (Fixes #70)
This commit is contained in:
Zeecka
2025-12-30 04:24:12 +01:00
committed by GitHub
2 changed files with 4 additions and 2 deletions
+1 -1
View File
@@ -5,7 +5,7 @@ WORKDIR /
# Install build tools and dependencies # Install build tools and dependencies
RUN apt-get update && apt-get install -y \ RUN apt-get update && apt-get install -y \
wget \ wget \
default-jre \ default-jdk \
ruby \ ruby \
zip \ zip \
7zip 7zip
+3 -1
View File
@@ -44,7 +44,9 @@ def analyze_binwalk(input_img: Path, output_dir: Path) -> None:
if extracted_dir.exists(): if extracted_dir.exists():
shutil.rmtree(extracted_dir) shutil.rmtree(extracted_dir)
if len(stderr) > 0: # Only report error if stderr exists AND extraction failed.
# If zip_exist is True, binwalk worked (despite warnings), so we proceed.
if len(stderr) > 0 and not zip_exist:
err = { err = {
"binwalk": { "binwalk": {
"status": "error", "status": "error",