From 566055e5eb39314a9adeedd752bfe762978070d7 Mon Sep 17 00:00:00 2001 From: aradhyacp Date: Tue, 30 Dec 2025 06:49:05 +0530 Subject: [PATCH 1/3] Fix Dockerfile to install default-jdk instead of default-jre to get jar --- Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Dockerfile b/Dockerfile index fe69aa9..41e4c21 100644 --- a/Dockerfile +++ b/Dockerfile @@ -5,7 +5,7 @@ WORKDIR / # Install build tools and dependencies RUN apt-get update && apt-get install -y \ wget \ - default-jre \ + default-jdk \ ruby \ zip \ 7zip From 54adcbcbfa61faf02dceb9e72db37153ebcdb267 Mon Sep 17 00:00:00 2001 From: aradhyacp Date: Tue, 30 Dec 2025 06:49:34 +0530 Subject: [PATCH 2/3] Fix error handling in binwalk analyzer to check for zip existence before reporting errors --- aperisolve/analyzers/binwalk.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/aperisolve/analyzers/binwalk.py b/aperisolve/analyzers/binwalk.py index 32d6fec..c3d1f2e 100644 --- a/aperisolve/analyzers/binwalk.py +++ b/aperisolve/analyzers/binwalk.py @@ -44,7 +44,7 @@ def analyze_binwalk(input_img: Path, output_dir: Path) -> None: if extracted_dir.exists(): shutil.rmtree(extracted_dir) - if len(stderr) > 0: + if len(stderr) > 0 and not zip_exist: err = { "binwalk": { "status": "error", From a2f6579380c310e89dcd032001947029c7884b3e Mon Sep 17 00:00:00 2001 From: aradhyacp Date: Tue, 30 Dec 2025 06:50:41 +0530 Subject: [PATCH 3/3] Clarify error reporting logic in binwalk analyzer comments --- aperisolve/analyzers/binwalk.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/aperisolve/analyzers/binwalk.py b/aperisolve/analyzers/binwalk.py index c3d1f2e..69920e7 100644 --- a/aperisolve/analyzers/binwalk.py +++ b/aperisolve/analyzers/binwalk.py @@ -44,6 +44,8 @@ def analyze_binwalk(input_img: Path, output_dir: Path) -> None: if extracted_dir.exists(): shutil.rmtree(extracted_dir) + # Only report error if stderr exists AND extraction failed. + # If zip_exist is True, binwalk worked (despite warnings), so we proceed. if len(stderr) > 0 and not zip_exist: err = { "binwalk": {