[GEMINI] Refactor tests to use Config class and autouse test isolation fixture

This commit is contained in:
venus
2026-07-19 02:55:11 -05:00
parent 7691b366f2
commit 7bd450abed
5 changed files with 129 additions and 169 deletions

View File

@@ -1,10 +1,10 @@
# tests/test_commands.py
from pathlib import Path
import toml
from click.testing import CliRunner
from ctf.commands import basic_group
from ctf.config import Config
TEST_ENV = Path("tests/env")
# {{{ test_basic_test_cli
def test_basic_test_cli():
"""
Verifies that 'basic test' runs successfully and outputs 'hello from test'.
@@ -13,7 +13,9 @@ def test_basic_test_cli():
result = runner.invoke(basic_group, ["test"])
assert result.exit_code == 0
assert "hello from test" in result.output
# }}}
# {{{ test_basic_greet_cli
def test_basic_greet_cli():
"""
Verifies that 'basic greet' runs successfully and greets the name argument.
@@ -22,65 +24,44 @@ def test_basic_greet_cli():
result = runner.invoke(basic_group, ["greet", "Alice"])
assert result.exit_code == 0
assert "hello Alice" in result.output
# }}}
# {{{ test_basic_set_flag_format_cli
def test_basic_set_flag_format_cli():
"""
Verifies that 'basic set-flag-format' CLI command writes the pattern to config.toml.
"""
from ctf.config import load_config
runner = CliRunner()
config_file = Path("/home/venus/code/ctf/config.toml")
# Save the original config to restore later
original_config = load_config(str(config_file))
cfg = Config()
assert cfg.data["Competition"]["flag_format"] == r"picoCTF\{.*\}"
try:
result = runner.invoke(basic_group, ["set-flag-format", "TEST_FLAG{[a-z]+}"])
assert result.exit_code == 0
assert "Flag format set to" in result.output
# Verify it was written to config.toml
updated_config = load_config(str(config_file))
assert updated_config["Competition"]["flag_format"] == "TEST_FLAG{[a-z]+}"
finally:
# Restore original config
from ctf.config import write_config
write_config(original_config, str(config_file))
result = runner.invoke(basic_group, ["set-flag-format", "TEST_FLAG{[a-z]+}"])
assert result.exit_code == 0
assert "Flag format set to" in result.output
updated_cfg = Config()
assert updated_cfg.data["Competition"]["flag_format"] == "TEST_FLAG{[a-z]+}"
# }}}
# {{{ test_basic_set_flag_format_original_option_cli
def test_basic_set_flag_format_original_option_cli():
"""
Verifies that 'basic set-flag-format' with --original/-o option prompts for selection and writes it.
"""
from ctf.config import load_config
runner = CliRunner()
config_file = Path("/home/venus/code/ctf/config.toml")
# Save the original config to restore later
original_config = load_config(str(config_file))
result = runner.invoke(basic_group, ["set-flag-format", "-o", "SKY-1111-000"], input="2\n")
assert result.exit_code == 0
assert "Select a pattern index" in result.output
assert "Flag format set to" in result.output
try:
# We pass -o SKY-1111-000 and input "2" to choose the second suggested pattern
result = runner.invoke(basic_group, ["set-flag-format", "-o", "SKY-1111-000"], input="2\n")
assert result.exit_code == 0
comp_name = original_config.get("Competition", {}).get("competition", "")
if comp_name:
assert f"Suggested regex patterns for competition {comp_name}:" in result.output
else:
assert "Suggested regex patterns:" in result.output
assert "Select a pattern index" in result.output
assert "Flag format set to" in result.output
# Verify it was written to config.toml
updated_config = load_config(str(config_file))
selected_pattern = updated_config["Competition"]["flag_format"]
assert len(selected_pattern) > 0
finally:
# Restore original config
from ctf.config import write_config
write_config(original_config, str(config_file))
updated_cfg = Config()
selected_pattern = updated_cfg.data["Competition"]["flag_format"]
assert len(selected_pattern) > 0
# }}}
# {{{ test_basic_set_flag_format_validation_cli
def test_basic_set_flag_format_validation_cli():
"""
Verifies validation rules:
@@ -104,53 +85,36 @@ def test_basic_set_flag_format_validation_cli():
result3 = runner.invoke(basic_group, ["set-flag-format", "-o", " "])
assert result3.exit_code != 0
assert "Original flag cannot be empty or whitespace only." in result3.output
# }}}
# {{{ test_basic_set_competition_cli
def test_basic_set_competition_cli():
"""
Verifies that 'basic set-competition' updates the competition name in config.toml.
"""
from ctf.config import load_config
runner = CliRunner()
config_file = Path("/home/venus/code/ctf/config.toml")
original_config = load_config(str(config_file))
result = runner.invoke(basic_group, ["set-competition", "CyberCTF2026"])
assert result.exit_code == 0
assert "Competition name set to: CyberCTF2026" in result.output
try:
result = runner.invoke(basic_group, ["set-competition", "CyberCTF2026"])
assert result.exit_code == 0
assert "Competition name set to: CyberCTF2026" in result.output
updated_config = load_config(str(config_file))
assert updated_config["Competition"]["competition"] == "CyberCTF2026"
finally:
from ctf.config import write_config
write_config(original_config, str(config_file))
updated_cfg = Config()
assert updated_cfg.data["Competition"]["competition"] == "CyberCTF2026"
# }}}
# {{{ test_basic_set_flag_format_warning_cli
def test_basic_set_flag_format_warning_cli():
"""
Verifies that if competition name is set and not present in the example flag,
set-flag-format outputs a warning.
"""
from ctf.config import load_config, write_config
runner = CliRunner()
config_file = Path("/home/venus/code/ctf/config.toml")
original_config = load_config(str(config_file))
try:
# Set competition name first
temp_config = load_config(str(config_file))
if "Competition" not in temp_config:
temp_config["Competition"] = {}
temp_config["Competition"]["competition"] = "SECURE"
write_config(temp_config, str(config_file))
# Now run set-flag-format with an example flag that has no "SECURE" substring
# We also pass input "1" to satisfy the choice prompt
result = runner.invoke(basic_group, ["set-flag-format", "-o", "CTF{easy_flag_123}"], input="1\n")
assert result.exit_code == 0
assert "Warning: Current competition name 'SECURE' was not found in the example flag." in result.output
finally:
write_config(original_config, str(config_file))
# Set competition name first
cfg = Config()
cfg.data["Competition"]["competition"] = "SECURE"
cfg.save(cfg.data)
result = runner.invoke(basic_group, ["set-flag-format", "-o", "CTF{easy_flag_123}"], input="1\n")
assert result.exit_code == 0
assert "Warning: Current competition name 'SECURE' was not found in the example flag." in result.output
# }}}